I'm not that familiar with newer c# code and only recently started with result pattern but tbh, I can't tell what is this code supposed to do. Does opt resolve to true or false in this case? Why do you want TestStringFail to always execute, and what should it return? Why is opt.None true when it was initialized with a valid string value, what does None even mean in this context?
- Posts
- 18
- Comments
- 109
- Joined
- 3 yr. ago
- Posts
- 18
- Comments
- 109
- Joined
- 3 yr. ago
Additional question - I said at first that the "Service" should be doing the mandatory checks like uniqueness validation or whether the fields are filled in properly with good values, but is even that a good approach?
Instead of implementing this in every service that might create a new Movie (and it could be from different sources - import from file, different APIs, background worker, etc), wouldn't it make more sense to add these checks to the repository itself so they always gets called?
Alternatively, do we have to handle a constraint violation in every service or could we just have the repository return a result with failure if it happens?
In short, once I start thinking in this way I start to wonder why even have a separation between repository and service.